Graphical JSON editor for secrets and policies #38
Conversation
|
Haven't looked at the PR yet but this looks 🥇awesome from the screenshots! |
| @@ -251,11 +268,12 @@ export default class Manage extends React.Component { | |||
| errorMessage: 'An error occurred.' | |||
| }); | |||
| } else { | |||
| debugger; | |||
There was a problem hiding this comment.
probably dont want this debugger line here.
There was a problem hiding this comment.
Whooops sorry that slipped. I'll clean it up
|
Solid work man. A lot to look into, but we'll merge this in and play around with the image for bugs and what not. We'll consider this a part of 0.2.0, so its release will depend on this features stability, amongst other things. @alexunwin hows it look to you? |
| @@ -0,0 +1,92 @@ | |||
| import React, { PropTypes } from 'react'; | |||
There was a problem hiding this comment.
Can we format this file with 4 spaces...looks like it using 2
|
Sounds good mate, let me know if you find any issue with the PR code and I'll fix it |
| currentPolicy.name = v; | ||
| } else if (e.target.name === "newRules") { | ||
| currentPolicy.rules = v; | ||
| let setNewPolicy = (v, syntaxCheckOk, schemaCheckOk) => { |
There was a problem hiding this comment.
This looks like it should be its own function, since you are reusing the same logic on L108
Intro
Integrate the excellent josdejong/jsoneditor to edit secrets and policies.
Schema validation is enforced on policies to aid the operator in writing correct syntax.
Note: Root Key behaviour for secrets has been preserved.
Screenshots
Secret creation
Policy creation with enforced schema check